fix for bad gateway error due to missing details on drupal - displays an error message #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an error message
amotenko
reviewed
Jan 17, 2018
| var tickets_array = []; | ||
| var drupal_user_id = _.get(drupal_user, 'user.uid'); | ||
| if (!drupal_user_id) { | ||
| done(false, i18next.t('invalid_user_id')); |
There was a problem hiding this comment.
This is the only change right, all the rest is indentation?
There was a problem hiding this comment.
mostly yes, you can see only the changes without whitespace changes by adding ?w=1 to the url - https://github.com/Midburn/spark/pull/577/files?w=1
amotenko
approved these changes
Jan 18, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #549 for reproduction steps - although it's hard to reproduce this bug (you need access to user profile which has the required conditions for this bug..)